This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
doc/how to add evaluation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
force-pushed
the
doc/how_to_add_evaluation
branch
from
b47368d to
e4fa70d
Compare
panyx0718
approved these changes
Mar 21, 2018
|
|
||
| ## Concepts | ||
|
|
||
| - `baseline`, one of the best KPI records in the history, the baseline should keep being updated. |
There was a problem hiding this comment.
should this be a running average or something similar? I'm afraid that the "best" one will be too good for the "normal" ones. But we can revisit this in the future.
doc/howto.md
Outdated
| ## Concepts | ||
|
|
||
| - `baseline`, one of the best KPI records in the history, the baseline should keep being updated. | ||
| - `Factor`, an alias for KPI to make the code more readable. |
There was a problem hiding this comment.
explain more about this?
doc/howto.md
Outdated
| from core import CostFactor, DurationFactor | ||
|
|
||
| train_cost_factor = CostFactor('train_cost', 0.15) | ||
| train_duration_factor = CostFactor('train_duration', 0.15) |
There was a problem hiding this comment.
Should this be DurationFactor?
Superjomn
force-pushed
the
doc/how_to_add_evaluation
branch
from
e4fa70d to
9b3915f
Compare
Superjomn
force-pushed
the
doc/how_to_add_evaluation
branch
from
9b3915f to
a55c804
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.